-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add references to introduction #39
Conversation
Bt601 does not appear in the reference section in the pdf |
pointing on 1 specific document which provides choices about transformations constants is maybe not the best choice (why BT.601 and not BT.709 or BT.2020?) |
It seems to me that Rec. 709 fits better the purpose than Rec. 601, but I plenty agree with @JeromeMartinez. I would recommend Charles Poynton (I also use Y′CBCR myself). |
faa78bd
to
1bcf045
Compare
Ready for review again. |
Refering to bt709 would suggest that no other YCbCr can be stored or that its implied to be bt709 "compatible" |
None of them, as bt709 is only one of the possibilities for YCbCr. |
Since the intro suggests that familiarity with YCbCr is assumed, I wanted to add a reference in case the reader needs that info. |
Having a reference is good, but having a specific YCbCr transformation as a reference may make people think that this is the "standard" method for FFV1 (and it is not). |
I suggested Rec. 709 because in my experience is what people request most those days. The Wikipedia entry is not completely correct, but Charles Poynton’s attemps to improve it failed. I’m OK with it, not less not more. |
Really depends of who you are talking to. In some other domains, this is XYZ (cinema, and they also use lossless video, but ok maybe out of topic it is not YCbCr) or HLG (broadcast, extending YCbCr from BT.2020 used for 4KK, and there are more and more 4K content). If we stay with a particular BT.xxx, maybe writing that this is only an example and that there is no endorsement of particular YCbCr transfer constants. |
Indeed! And I know why… ;-) The colour space XYZ is the origin which is meant to represent scientifically the view of an average trichromat. As said, I’m OK with the Wikipedia entry for Y′CBCR. |
intended to resolve FFmpeg#14
1bcf045
to
3a9ae9d
Compare
Updated from ITU bt709 to Wikipedia:YCbCr |
LGTM |
intended to resolve #14